Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup mosaic/read_mosaic.c #1345

Closed
wants to merge 3 commits into from
Closed

cleanup mosaic/read_mosaic.c #1345

wants to merge 3 commits into from

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Aug 18, 2023 •
edited
Loading

Description
In this PR,

  • read_mosaic.c file in the mosaic directory has been renamed to get_global_area.c.

  • In get_global_area.c, all functions with the exception of get_global_area have been removed. These functions have been removed because they are unused.

  • Unnecessary OVERLOAD_R4 statements have been removed.

This PR is necessary for mixed-precision updates to mosaic2_mod.

Fixes #1344

How Has This Been Tested?
Make check finishes successful with Intel and GCC on the AMD box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

mlee03
mlee03 commented Aug 18, 2023
View reviewed changes
mosaic/get_global_area.c
@@ -0,0 +1,57 @@
/***********************************************************************
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used git mv to move read_mosaic.c to get_global_area.c so that Github knows which files to compare, but seems like it's not working here.

@mlee03
Copy link
Contributor Author

mlee03 commented Sep 6, 2023

@rem1776, is it possible to retrigger the CI on this PR?

@rem1776
Copy link
Contributor

rem1776 commented Sep 6, 2023

@rem1776, is it possible to retrigger the CI on this PR?

Should be running now

@mlee03
Copy link
Contributor Author

mlee03 commented Sep 11, 2023

Closing. Working on a PR that cleans up more of mosaic c files as described in Issue #1344

@mlee03 mlee03 closed this Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rem1776 rem1776 Awaiting requested review from rem1776 rem1776 is a code owner

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

@bensonr bensonr Awaiting requested review from bensonr bensonr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup the directory mosaic
2 participants
@mlee03 @rem1776